Re: Thumb on 2.4.x

Top Page
Attachments:
Message as email
+ (text/plain)
Delete this message
Reply to this message
Author: Andre
Date:  
To: Russell King - ARM Linux
CC: linux-arm-kernel
Subject: Re: Thumb on 2.4.x
Russell King - ARM Linux wrote:
>
> Nice catch.
>
> Ok, the growing patch for ARM720T thumb is now:


Thanks Russell !!

However, I think your patch must have been truncated in the mailing
process somehow... As well as the early FAR/FSR read change which you
seem to be missing ;-), I also needed the following additional
tweaks:

--- linux/arch/arm/mm/proc-arm720.S   6 Jan 2004 04:38:40 -0000
+++ linux/arch/arm/mm/proc-arm720.S   24 Feb 2004 01:46:33 -0000
@@ -324,8 +324,8 @@
        and     r0, r0, #15             @ number of regs to transfer
        ldr     r7, [sp, #13 << 2]
        tst     r4, #1 << 11
-       addne   r7, r7, r0, lsl #2      @ increment SP if PUSH
-       subeq   r7, r7, r0, lsr #2      @ decrement SP if POP
+       addeq   r7, r7, r0, lsl #2      @ increment SP if PUSH
+       subne   r7, r7, r0, lsl #2      @ decrement SP if POP
        str     r7, [sp, #13 << 2]
        b       Ldata_simple


No guarantees that Thumb is now 100% working, but it's good enough to
run the klibc sample apps (hello, minips, ash, etc) statically linked
with a nice reduction in code size compared to ARM mode, eg for ash:

$ size sh_arm sh_thumb 
   text    data     bss     dec     hex filename
  62492    1176    7460   71128   115d8 sh_arm
  44116    1176    7460   52752    ce10 sh_thumb


Andre
--

__________________________________
Do you Yahoo!?
Yahoo! Mail SpamGuard - Read only the mail you want.
http://antispam.yahoo.com/tools